Fix WrapLayout sometimes will collapsing#695
Fix WrapLayout sometimes will collapsing#695h82258652 wants to merge 2 commits intoCommunityToolkit:mainfrom
Conversation
|
@h82258652 thanks for the PR, would you mind adding some more detail here about why this was causing the issue and how this resolves it (behaviorally)? It could be good to add a test case as well that exhibits the issue and then gets resolved by the fix. Looking at the original PR from @skendrot, https://github.com/CommunityToolkit/WindowsCommunityToolkit/pull/3160/files#diff-17bbc9815eb822dd6326ef64483a5d0cfa07a46b1085227ce7299819b0c61956R200-R208 - it seems like the continue wasn't originally here, so I wonder where it was added and what that was trying to resolve for some other issue maybe? A different fix had added this continue by @Poker-sang here: #187 - It'd be good to add some various tests to these underlying issues and ensure we're covering all the scenarios between bug #690 and #70. |
2 participants
Fixes #690
This PR fixes the
WrapLayoutsometimes will collapsing all the items.PR Type
What kind of change does this PR introduce?
What is the current behavior?
Sometimes, all the items in the
WrapLayoutwill be collapsed together.What is the new behavior?
All the items should be positioned correctly.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information